fix: DLL versioning for SDK usage as CMake subdirectory#1086
Merged
supervacuus merged 2 commits intomasterfrom Nov 20, 2024
Merged
fix: DLL versioning for SDK usage as CMake subdirectory#1086supervacuus merged 2 commits intomasterfrom
supervacuus merged 2 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
- Coverage 82.41% 82.36% -0.06%
==========================================
Files 53 53
Lines 7751 7751
Branches 1216 1216
==========================================
- Hits 6388 6384 -4
- Misses 1251 1254 +3
- Partials 112 113 +1
|
|
@supervacuus it worked! thanks for the fix 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue raised in #1084.
@dacap, can you give this a try in your setup?