feat: add support for SOCKS5 proxy#1063
Merged
JoshuaMoelans merged 42 commits intomasterfrom Nov 21, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1063 +/- ##
==========================================
+ Coverage 82.38% 82.43% +0.04%
==========================================
Files 53 53
Lines 7751 7760 +9
Branches 1216 1215 -1
==========================================
+ Hits 6386 6397 +11
Misses 1253 1253
+ Partials 112 110 -2
|
JoshuaMoelans
commented
Oct 30, 2024
JoshuaMoelans
commented
Oct 30, 2024
|
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
supervacuus
requested changes
Nov 18, 2024
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
This looks great, thanks! Just a few minor changes and questions.
# Conflicts: # CHANGELOG.md
(let's hope I didn't mess up CI)
6 tasks
supervacuus
approved these changes
Nov 21, 2024
Collaborator
supervacuus
left a comment
There was a problem hiding this comment.
Thanks! I know this was quite the odyssey, but the resulting integration tests alone are worth the pain ❤️.
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
Co-authored-by: Mischan Toosarani-Hausberger <mischan@abovevacant.com>
…eat/socks5_proxy_joshua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1030
Todo
-> currently checked for MacOS using Curl transport
-> using
mitmproxymitmproxy-> replaced by adding it to
requirements.txt-> especially about socks5 being circumvented if proxy is unavailable on mac
-> similar story on Windows with Autoproxy circumventing the proxy if a connection is possible
-> ❗️ this only manifested in the
capturetest, NOT in thecrashtest -> ToDo: reason about why crashpad doesn't autoproxy?-> document which transports/platforms don't support it (e.g. winhttp)