fix(node): Disable LocalVariables integration on Node < v18#7748
Merged
AbhiPrasad merged 7 commits intogetsentry:developfrom Apr 5, 2023
Merged
fix(node): Disable LocalVariables integration on Node < v18#7748AbhiPrasad merged 7 commits intogetsentry:developfrom
LocalVariables integration on Node < v18#7748AbhiPrasad merged 7 commits intogetsentry:developfrom
Conversation
Contributor
|
I refactored the node version constant usage in the SDK - #7734, so we'll prob have to adjust this based on that. |
AbhiPrasad
reviewed
Apr 5, 2023
Collaborator
Author
|
Not sure what's going on here. The tests pass locally under Node v16! |
Contributor
|
Should we only run the local variables unit tests in Node 18 and above? |
Collaborator
Author
|
Oh yes, thanks! |
AbhiPrasad
reviewed
Apr 5, 2023
Contributor
|
Marking this ready to review because we want to do a release today. |
AbhiPrasad
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the v8 inspector API has some incompatibilities with domains and async which cause them to not be GC'd in a reasonable timeframe for it to be used in production applications.
This PR causes the
LocalVariablesintegration not to be enabled if the Node version is less than v18.