fix(core): Determine debug ID paths from the top of the stack#7722
Merged
fix(core): Determine debug ID paths from the top of the stack#7722
Conversation
AbhiPrasad
approved these changes
Apr 4, 2023
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In node (and probably other platforms too), the bottom frame of a trace often contains native code/filenames. See "internal/main/run_main_module.js" below:
[ { "function": "<anonymous>", "module": "run_main_module", "filename": "internal/main/run_main_module.js", "abs_path": "internal/main/run_main_module.js", "lineno": 17, "colno": 47, "in_app": false }, { "function": "Function.executeUserEntryPoint [as runMain]", "module": "run_main", "filename": "internal/modules/run_main.js", "abs_path": "internal/modules/run_main.js", "lineno": 75, "colno": 12, "in_app": false }, { "function": "Module._load", "module": "loader", "filename": "internal/modules/cjs/loader.js", "abs_path": "internal/modules/cjs/loader.js", "lineno": 790, "colno": 12, "in_app": false }, { "function": "Module.load", "module": "loader", "filename": "internal/modules/cjs/loader.js", "abs_path": "internal/modules/cjs/loader.js", "lineno": 950, "colno": 32, "in_app": false }, { "function": "Module._extensions..js", "module": "loader", "filename": "internal/modules/cjs/loader.js", "abs_path": "internal/modules/cjs/loader.js", "lineno": 1114, "colno": 10, "in_app": false }, { "function": "Module._compile", "module": "loader", "filename": "internal/modules/cjs/loader.js", "abs_path": "internal/modules/cjs/loader.js", "lineno": 1085, "colno": 14, "in_app": false }, { "function": "Object.<anonymous>", "module": "entrypoint3", "filename": "/Users/lucaforstner/code/github/getsentry/sentry-javascript-bundler-plugins/packages/playground/out/rollup/entrypoint3.js", "abs_path": "/Users/lucaforstner/code/github/getsentry/sentry-javascript-bundler-plugins/packages/playground/out/rollup/entrypoint3.js", "lineno": 58, "colno": 36, "in_app": true } ]Up until now, for debug ID resolving, we took the first frame that had a filename from the bottom of the stack. When an error occurs, In the lookup logic of the debug IDs we go from the top, meaning that the debug ID will not work when there are native frames/filenames.
This pr fixes this by simply going through the stack frame in reverse.