fix(nextjs): Restore tree shaking capabilities#7710
Merged
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Apr 3, 2023
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
Can we test this to make sure we don't regress?
Also did you validate with a local app? Can you show before/after in the PR?
Contributor
Author
We already have tests in place for this! E2E tests would fail if this would eliminate side effects somehow.
Well, I just tried it out locally, and turns out replay does properly tree shake away in my Next.js 13 test application, regardless of this change. Maybe it is related to older webpack versions. I am still going to go forward with this because it is more correct this way. |
mydea
approved these changes
Apr 3, 2023
3 tasks
Contributor
|
I've crated somewhat relevant #7713 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We messed up in #6592 and destroyed tree shaking capabilities for webpack by entirely removing the
sideEffectsfield in the package.json. This PR adds it back so tree shaking should be possible again.Hopefully fixes #7680