fix(angular): Handle routes with empty path#7686
Conversation
a7f013a to
2f4419e
Compare
Lms24
left a comment
There was a problem hiding this comment.
Hey @de-don, thanks for opening this PR!
This fix generally LGTM so I hope we can get it in soon. Can you please tell us with which Angular version you tested this change? Since we support Angular 10 to 15, we should make sure we tested it at least in NG10 and NG15.
Update function getParameterizedRouteFromSnapshot to handle routes with empty paths. Fixes getsentryGH-7681
2f4419e to
a335165
Compare
I have tested this code on my project with The main idea of this code, that we should proceed with |
|
Thanks for your response @de-don! I have just tested this in NG10 and it still seems to work. Will ✅ and merge soon. Thanks again for contributing!
FYI, technically, that's true but the routing instrumentation is unit-tested without Angular's testbed/testing environment. It just unit-tests the |
Update function getParameterizedRouteFromSnapshot to handle routes with empty paths.
Fixes GH-7681
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).