feat(visionOS): Enable MetricKit Integration for visionOS#7466
Merged
Conversation
Enable MetricKit Integration for visionOS
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7466 +/- ##
=============================================
+ Coverage 85.301% 85.324% +0.023%
=============================================
Files 480 480
Lines 28621 28620 -1
Branches 12383 12387 +4
=============================================
+ Hits 24414 24420 +6
+ Misses 4157 4150 -7
Partials 50 50
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 79e2bb8 | 1216.37 ms | 1242.42 ms | 26.05 ms |
| a180235 | 1222.87 ms | 1255.10 ms | 32.23 ms |
| 4b41eee | 1209.96 ms | 1243.12 ms | 33.16 ms |
| 3bff9ff | 1217.72 ms | 1246.43 ms | 28.71 ms |
| 24ac927 | 1218.04 ms | 1242.02 ms | 23.98 ms |
| 870ddae | 1224.24 ms | 1249.45 ms | 25.21 ms |
| 79cee27 | 1214.65 ms | 1238.66 ms | 24.01 ms |
| 0e4b033 | 1203.74 ms | 1249.71 ms | 45.97 ms |
| 47c9f79 | 1216.57 ms | 1240.94 ms | 24.37 ms |
| c796e6d | 1226.33 ms | 1247.33 ms | 21.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 79e2bb8 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| a180235 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| 4b41eee | 24.14 KiB | 1.09 MiB | 1.07 MiB |
| 3bff9ff | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| 24ac927 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 870ddae | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| 79cee27 | 24.14 KiB | 1.10 MiB | 1.08 MiB |
| 0e4b033 | 24.14 KiB | 1.11 MiB | 1.09 MiB |
| 47c9f79 | 24.14 KiB | 1.09 MiB | 1.06 MiB |
| c796e6d | 24.14 KiB | 1.11 MiB | 1.09 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable MetricKit Integration for visionOS
📜 Description
💡 Motivation and Context
Closes #6458
💚 How did you test it?
Unite tests. Cannot simulate MetricKit payload from Xcode debug menu, as this is apparently only available for real hardware. Could launch the simulator app though with installed integration.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.