feat: Hang tracker using runloop observer by noahsmartin · Pull Request #7464 · getsentry/sentry-cocoa

noahsmartin · 2026-02-15T02:27:28Z

Converts the watchdog tracker to use a runloop observer. This avoids a CADisplayLink constantly spinning the main runloop. The hang tracker class is generic enough to be used for other use cases that are currently using display links.

Closes #7470

github-actions · 2026-02-15T02:27:46Z

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

Hang tracker using runloop observer by noahsmartin in #7464

Bug Fixes 🐛

(profiling) Remove launch profiling logs in sandboxed environments breaking CLI tools by philprime in #7294
Preserve NSException reason over unrelated crash_info_message by philprime in #7515

Documentation 📚

(ci) Add Cirrus Labs runner documentation by itaybre in #7522
Deprecate CocoaPods support in README by itaybre in #7526

Internal Changes 🔧

(ci) Update CI configurations to use runner concurrency groups by itaybre in #7511
Don't swiftlint generated sample code by 43jay in #7524
Remove unused .oclint config by philipphofmann in #7542
Remove unused .nvmrc by philipphofmann in #7540
Remove empty .gitmodules file by philipphofmann in #7538

Other

Fix optional chaining for window property access by benjaminpeters in #7508

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-02-15T02:27:56Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c850e00

codecov · 2026-02-15T02:30:31Z

Codecov Report

❌ Patch coverage is 93.60000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.923%. Comparing base (b1994b3) to head (c850e00).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...SentryWatchdogTerminationTrackingIntegration.swift	83.333%	5 Missing ⚠️
Sources/Swift/HangTracker.swift	96.774%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #7464       +/-   ##
=============================================
+ Coverage   85.272%   85.923%   +0.650%     
=============================================
  Files          479       480        +1     
  Lines        28620     28742      +122     
  Branches     12444     12504       +60     
=============================================
+ Hits         24405     24696      +291     
+ Misses        4168      3998      -170     
- Partials        47        48        +1

Files with missing lines	Coverage Δ
Sources/Swift/SentryDependencyContainer.swift	`97.183% <100.000%> (+0.013%)`	⬆️
Sources/Swift/SentryExperimentalOptions.swift	`80.000% <100.000%> (+5.000%)`	⬆️
Sources/Swift/HangTracker.swift	`96.774% <96.774%> (ø)`
...SentryWatchdogTerminationTrackingIntegration.swift	`87.500% <83.333%> (-1.631%)`	⬇️

... and 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1994b3...c850e00. Read the comment docs.

github-actions · 2026-02-15T04:21:04Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1219.84 ms	1244.64 ms	24.80 ms
Size	24.14 KiB	1.12 MiB	1.09 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`f38f4e9`	1221.50 ms	1242.64 ms	21.14 ms
`d69379c`	1211.30 ms	1234.77 ms	23.47 ms
`2d59844`	1208.98 ms	1245.25 ms	36.27 ms
`1357911`	1222.84 ms	1258.38 ms	35.54 ms
`b984142`	1222.18 ms	1257.77 ms	35.59 ms
`aa58669`	1218.51 ms	1258.55 ms	40.04 ms
`5ca545a`	1219.06 ms	1244.59 ms	25.53 ms
`3bf0d3f`	1202.12 ms	1237.23 ms	35.11 ms
`93ef486`	1220.22 ms	1244.96 ms	24.74 ms
`fee8669`	1220.50 ms	1231.84 ms	11.34 ms

App size

Revision	Plain	With Sentry	Diff
`f38f4e9`	24.14 KiB	1.10 MiB	1.07 MiB
`d69379c`	24.14 KiB	1.11 MiB	1.09 MiB
`2d59844`	24.14 KiB	1.09 MiB	1.06 MiB
`1357911`	24.14 KiB	1.07 MiB	1.04 MiB
`b984142`	24.14 KiB	1.11 MiB	1.09 MiB
`aa58669`	24.14 KiB	1.10 MiB	1.07 MiB
`5ca545a`	24.14 KiB	1.06 MiB	1.04 MiB
`3bf0d3f`	24.14 KiB	1.04 MiB	1.02 MiB
`93ef486`	24.14 KiB	1.06 MiB	1.04 MiB
`fee8669`	24.14 KiB	1.10 MiB	1.08 MiB

Previous results on branch: hangTrackerAbstraction2

Startup times

Revision	Plain	With Sentry	Diff
`80dcd49`	1215.90 ms	1248.20 ms	32.30 ms
`9381615`	1199.08 ms	1229.09 ms	30.01 ms
`29c1d77`	1224.26 ms	1260.20 ms	35.94 ms
`c7d530c`	1221.96 ms	1259.06 ms	37.11 ms
`3488362`	1205.75 ms	1244.83 ms	39.08 ms
`052a331`	1226.04 ms	1263.20 ms	37.16 ms
`1ea2069`	1224.09 ms	1255.49 ms	31.40 ms
`555ec8a`	1227.52 ms	1260.31 ms	32.78 ms
`a286479`	1227.00 ms	1259.46 ms	32.46 ms
`c961e27`	1212.32 ms	1252.95 ms	40.64 ms

App size

Revision	Plain	With Sentry	Diff
`80dcd49`	24.14 KiB	1.12 MiB	1.10 MiB
`9381615`	24.14 KiB	1.12 MiB	1.09 MiB
`29c1d77`	24.14 KiB	1.12 MiB	1.09 MiB
`c7d530c`	24.14 KiB	1.12 MiB	1.10 MiB
`3488362`	24.14 KiB	1.12 MiB	1.09 MiB
`052a331`	24.14 KiB	1.12 MiB	1.09 MiB
`1ea2069`	24.14 KiB	1.12 MiB	1.09 MiB
`555ec8a`	24.14 KiB	1.12 MiB	1.09 MiB
`a286479`	24.14 KiB	1.12 MiB	1.10 MiB
`c961e27`	24.14 KiB	1.12 MiB	1.10 MiB

philipphofmann · 2026-02-17T09:04:15Z

@noahsmartin, as the PR description states WIP, I converted this to a draft PR so it clearly signals it's not ready for review. Feel free to make it ready for review once it's ready 😃

philipphofmann · 2026-02-17T15:33:48Z

@cursoragent review

philipphofmann · 2026-02-17T15:33:56Z

@claude review

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the [Cursor dashboard](https://www.cursor.com/dashboard?tab=bugbot).}

philprime

@noahsmartin please review and resolve all open comments so we can merge it. I am uncertain which ones you already addressed

philprime

LGTM, it's experimental now so we can iterate on it 👍 Thank you for tackling this. I'll add the CHANGELOG.md and update the public API json so we can get this done

noahsmartin force-pushed the hangTrackerAbstraction2 branch from 5d87757 to 504fe19 Compare February 15, 2026 02:28

noahsmartin added the ready-to-merge Use this label to trigger all PR workflows label Feb 15, 2026

noahsmartin force-pushed the hangTrackerAbstraction2 branch 5 times, most recently from 4c15468 to 9804e83 Compare February 15, 2026 03:55

noahsmartin force-pushed the hangTrackerAbstraction2 branch from 9804e83 to 59b2337 Compare February 15, 2026 04:22

noahsmartin marked this pull request as ready for review February 17, 2026 00:46

noahsmartin requested review from itaybre, philipphofmann and philprime as code owners February 17, 2026 00:46

github-actions Bot mentioned this pull request Feb 17, 2026

feat: Hang tracker using runloop observer #7470

Closed

sentry Bot reviewed Feb 17, 2026

View reviewed changes

Comment thread Sources/Swift/HangTracker.swift

noahsmartin force-pushed the hangTrackerAbstraction2 branch 2 times, most recently from d96e106 to 7bc3d16 Compare February 17, 2026 00:56

cursor Bot reviewed Feb 17, 2026

View reviewed changes

philipphofmann marked this pull request as draft February 17, 2026 09:04

noahsmartin marked this pull request as ready for review February 17, 2026 15:29

This comment was marked as outdated.

Sign in to view

cursor Bot reviewed Feb 17, 2026

View reviewed changes

Comment thread Sources/Swift/HangTracker.swift

Comment thread ...s/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationTrackingIntegration.swift

noahsmartin force-pushed the hangTrackerAbstraction2 branch from 32d11ec to 873f1aa Compare February 17, 2026 16:10

cursor Bot reviewed Feb 17, 2026

View reviewed changes

Comment thread Sources/Swift/HangTracker.swift

Writing/style fixes

88673a9

cursor Bot reviewed Feb 24, 2026

View reviewed changes

Comment thread ...s/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationTrackingIntegration.swift

sentry Bot reviewed Feb 24, 2026

View reviewed changes

Comment thread ...s/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationTrackingIntegration.swift Outdated

Copilot AI review requested due to automatic review settings February 24, 2026 18:36

Copilot started reviewing on behalf of noahsmartin February 24, 2026 18:37 View session

Add new tests

27df776

noahsmartin force-pushed the hangTrackerAbstraction2 branch from 66a955f to 27df776 Compare February 24, 2026 18:40

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Some more tests

69c5bf0

cursor Bot reviewed Feb 25, 2026

View reviewed changes

Comment thread Tests/SentryTests/Integrations/ANR/HangTrackerTests.swift Outdated

Comment thread Tests/SentryTests/Integrations/ANR/HangTrackerTests.swift Outdated

Copilot AI review requested due to automatic review settings February 25, 2026 01:42

noahsmartin force-pushed the hangTrackerAbstraction2 branch from 5530258 to a324e68 Compare February 25, 2026 01:42

Copilot started reviewing on behalf of noahsmartin February 25, 2026 01:43 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

cursor Bot reviewed Feb 25, 2026

View reviewed changes

Comment thread Tests/SentryTests/Integrations/ANR/HangTrackerTests.swift Outdated

Comment thread Tests/SentryTests/Integrations/ANR/HangTrackerTests.swift Outdated

Add more tests

1c6a7f6

noahsmartin force-pushed the hangTrackerAbstraction2 branch from a324e68 to 1c6a7f6 Compare February 25, 2026 02:19

philprime reviewed Feb 25, 2026

View reviewed changes

Comment thread ...s/Swift/Integrations/WatchdogTerminations/SentryWatchdogTerminationTrackingIntegration.swift

philprime reviewed Feb 25, 2026

View reviewed changes

Add experimental option

acc724d

philprime approved these changes Feb 27, 2026

View reviewed changes

philprime added 3 commits February 27, 2026 10:58

Merge remote-tracking branch 'origin/main' into hangTrackerAbstraction2

1a6ec98

update public API

3e2b9a1

add changelog entry

4e06e3a

philprime enabled auto-merge (squash) February 27, 2026 10:01

update changelog

c850e00

philprime mentioned this pull request Feb 27, 2026

ref: Use RunLoop observer for watchdog detection #6237

Closed

philprime merged commit 5dcea74 into main Feb 27, 2026
209 checks passed

philprime deleted the hangTrackerAbstraction2 branch February 27, 2026 11:23

philprime mentioned this pull request Feb 27, 2026

App Hang/Session Replay should use runloop observers #5263

Open

Uh oh!

Conversation

noahsmartin commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

New Features ✨

Bug Fixes 🐛

Documentation 📚

Internal Changes 🔧

Other

Uh oh!

github-actions Bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: hangTrackerAbstraction2

Startup times

App size

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philipphofmann commented Feb 17, 2026

Uh oh!

philipphofmann commented Feb 17, 2026

Uh oh!

philipphofmann commented Feb 17, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noahsmartin commented Feb 15, 2026 •

edited

Loading

github-actions Bot commented Feb 15, 2026 •

edited

Loading

github-actions Bot commented Feb 15, 2026 •

edited

Loading

codecov Bot commented Feb 15, 2026 •

edited

Loading

github-actions Bot commented Feb 15, 2026 •

edited

Loading

philprime left a comment •

edited

Loading