fix(metrics)!: Remove unit from public API for counter#7358
Merged
Conversation
Contributor
Semver Impact of This PR🔴 Major (breaking changes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7358 +/- ##
=============================================
+ Coverage 85.243% 85.250% +0.007%
=============================================
Files 477 477
Lines 28577 28577
Branches 12418 12420 +2
=============================================
+ Hits 24360 24362 +2
+ Misses 4173 4168 -5
- Partials 44 47 +3
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7714225 | 1213.24 ms | 1252.28 ms | 39.04 ms |
| 1357911 | 1222.84 ms | 1258.38 ms | 35.54 ms |
| 45eb835 | 1210.40 ms | 1233.39 ms | 22.99 ms |
| d540ef3 | 1214.37 ms | 1241.06 ms | 26.69 ms |
| b8fcca6 | 1228.85 ms | 1259.59 ms | 30.74 ms |
| ffe0649 | 1213.35 ms | 1248.64 ms | 35.29 ms |
| 5ca545a | 1219.06 ms | 1244.59 ms | 25.53 ms |
| 015d376 | 1187.58 ms | 1211.28 ms | 23.70 ms |
| c519f01 | 1211.75 ms | 1244.48 ms | 32.73 ms |
| 1357911 | 1224.57 ms | 1261.00 ms | 36.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7714225 | 24.14 KiB | 1.07 MiB | 1.05 MiB |
| 1357911 | 24.14 KiB | 1.07 MiB | 1.04 MiB |
| 45eb835 | 24.14 KiB | 1.07 MiB | 1.04 MiB |
| d540ef3 | 24.14 KiB | 1.07 MiB | 1.04 MiB |
| b8fcca6 | 24.14 KiB | 1.08 MiB | 1.06 MiB |
| ffe0649 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 5ca545a | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 015d376 | 24.14 KiB | 1.09 MiB | 1.07 MiB |
| c519f01 | 24.14 KiB | 1.08 MiB | 1.06 MiB |
| 1357911 | 24.14 KiB | 1.07 MiB | 1.04 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR introduces a breaking change of the experimental public API of metrics by removing the optional parameter
unitfor collecting counter metrics.💡 Motivation and Context
During revision of the Method Signatures of the metrics API in the develop docs it was surfaced to me that count metrics do not accept a Metric Unit.
💚 How did you test it?
Tested via unit tests
Closes #7359