fix(deploys): Honor --project in deploys new subcommand#2160
Merged
szokeasaurusrex merged 1 commit intomasterfrom Sep 20, 2024
Merged
fix(deploys): Honor --project in deploys new subcommand#2160szokeasaurusrex merged 1 commit intomasterfrom
--project in deploys new subcommand#2160szokeasaurusrex merged 1 commit intomasterfrom
Conversation
Previously, we ignored the `--project` arguments passed to the `sentry-cli deploys new` command. Regardless of whether any `--project` was provided, the deploy was created for all projects associated with the given release. Now, we respect the `--project` argument. If provided, we only create the deploy for the project(s) specified. If omitted, the deploy is created for all projects associated with the release, as previously. Fixes #2156
loewenheim
approved these changes
Sep 20, 2024
This was referenced Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we ignored the
--projectarguments passed to thesentry-cli deploys newcommand. Regardless of whether any--projectwas provided, the deploy was created for all projects associated with the given release.Now, we respect the
--projectargument. If provided, we only create the deploy for the project(s) specified. If omitted, the deploy is created for all projects associated with the release, as previously.Fixes #2156