Skip to content

Fix: Use task logger instead of project logger#165

Merged
cortinico merged 2 commits intogetsentry:mainfrom
cerisier:patch-1
Aug 24, 2021
Merged

Fix: Use task logger instead of project logger#165
cortinico merged 2 commits intogetsentry:mainfrom
cerisier:patch-1

Conversation

@cerisier
Copy link
Copy Markdown
Contributor

📜 Description

Invocation of Task.project is forbidden at execution time to comply with configuration cache requirements.
This was the last instance of Task.project that was making config cache fail for my project.

💡 Motivation and Context

Fixes Gradle configuration cache compliance.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Invocation of Task.project is forbidden at execution time to comply with configuration cache requirements.
Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.
Can you add line to the changelog and we can merge it

@marandaneto
Copy link
Copy Markdown
Contributor

@cerisier thanks for fixing this :)
add changelog and GG :)

@cerisier
Copy link
Copy Markdown
Contributor Author

Done.

@cerisier cerisier changed the title Use task logger instead of project logger Fix: Use task logger instead of project logger Aug 24, 2021
@cortinico cortinico merged commit f398e83 into getsentry:main Aug 24, 2021
@cerisier cerisier deleted the patch-1 branch August 25, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants