Skip to content

mbeliaev/max retry#536

Merged
markstory merged 1 commit intogetsentry:masterfrom
beliaev-maksim:mbeliaev/max_retry
Apr 11, 2022
Merged

mbeliaev/max retry#536
markstory merged 1 commit intogetsentry:masterfrom
beliaev-maksim:mbeliaev/max_retry

Conversation

@beliaev-maksim
Copy link
Copy Markdown
Collaborator

closes #135

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2022

Codecov Report

Merging #536 (3f7548b) into master (2a049bd) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3f7548b differs from pull request most recent head 3559a3b. Consider uploading reports for the commit 3559a3b to get more accurate results

@@            Coverage Diff            @@
##            master      #536   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2454      2530   +76     
=========================================
+ Hits          2454      2530   +76     
Impacted Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)
responses/tests/test_responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a049bd...3559a3b. Read the comment docs.

@beliaev-maksim beliaev-maksim marked this pull request as draft April 7, 2022 13:51
@beliaev-maksim beliaev-maksim marked this pull request as ready for review April 7, 2022 14:14
"""Validate that every new request uses brand-new Retry object"""

@responses.activate(registry=registries.OrderedRegistry)
def run():
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Forty-Bot this example is very similar to your use case

Comment thread README.rst Outdated
Comment thread responses/tests/test_responses.py Outdated
Co-authored-by: Mark Story <mark@mark-story.com>
@Forty-Bot
Copy link
Copy Markdown

Tested-by: Sean Anderson seanga2@gmail.com

@markstory markstory merged commit bdc5eff into getsentry:master Apr 11, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/max_retry branch April 11, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test Max Retries

3 participants