Skip to content

remove readonly properties#497

Merged
markstory merged 9 commits intogetsentry:masterfrom
beliaev-maksim:mbeliaev/properties
Mar 17, 2022
Merged

remove readonly properties#497
markstory merged 9 commits intogetsentry:masterfrom
beliaev-maksim:mbeliaev/properties

Conversation

@beliaev-maksim
Copy link
Copy Markdown
Collaborator

@beliaev-maksim beliaev-maksim commented Feb 9, 2022

currently we expose 2 attributes, users may think that changing them will affect something, but it is not
best example to show:

import responses

print(responses.assert_all_requests_are_fired)
responses.assert_all_requests_are_fired = True
print(responses.assert_all_requests_are_fired)
print(responses.mock.assert_all_requests_are_fired)

produces

False
True
False

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2022 •
edited
Loading

Codecov Report

Merging #497 (cb46489) into master (ce8a429) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #497   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2292      2305   +13     
=========================================
+ Hits          2292      2305   +13
Impacted Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)
responses/tests/test_responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8a429...cb46489. Read the comment docs.

@beliaev-maksim
Copy link
Copy Markdown
Collaborator Author

beliaev-maksim commented Feb 9, 2022

tests fail, #495 should fix it

@markstory
Copy link
Copy Markdown
Member

markstory commented Feb 16, 2022

I'm concerned that we'll break user-land code by taking these away. Given the impacts of past clean up changes, we've seen that user-land code is using several internals (eg. _is_string). Perhaps we should add a property wrapper for these and emit deprecation warnings?

@beliaev-maksim
Copy link
Copy Markdown
Collaborator Author

beliaev-maksim commented Feb 17, 2022

also a valid argument

any ideas how to create a property without a class instance?
since now it is just a variable in the module, eg responses.assert_all_requests_are_fired

@beliaev-maksim beliaev-maksim mentioned this pull request Feb 21, 2022
Merged
@aburgel
Copy link
Copy Markdown
Contributor

aburgel commented Feb 21, 2022

any ideas how to create a property without a class instance?

you can do something like this to deprecate these module attributes: https://www.python.org/dev/peps/pep-0562/

@beliaev-maksim
Copy link
Copy Markdown
Collaborator Author

beliaev-maksim commented Feb 22, 2022

any ideas how to create a property without a class instance?

you can do something like this to deprecate these module attributes: https://www.python.org/dev/peps/pep-0562/

Sounds like an idea, I will try it
Thanks

@beliaev-maksim
Copy link
Copy Markdown
Collaborator Author

beliaev-maksim commented Mar 4, 2022

@markstory
can you please review?

@beliaev-maksim
Merge branch 'master' into mbeliaev/properties
c279d2a 
# Conflicts:
#	CHANGES
#	responses/__init__.py
@beliaev-maksim beliaev-maksim mentioned this pull request Mar 11, 2022
Merged
@beliaev-maksim
Copy link
Copy Markdown
Collaborator Author

beliaev-maksim commented Mar 14, 2022

@markstory
merge conflicts are resolved

@markstory markstory merged commit 1724937 into getsentry:master Mar 17, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/properties branch March 17, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beliaev-maksim @markstory @aburgel