Fix 464#470
Merged
markstory merged 6 commits intogetsentry:masterfrom Jan 12, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1999 2026 +27
=========================================
+ Hits 1999 2026 +27
Continue to review full report at Codecov.
|
markstory
reviewed
Jan 12, 2022
added tests to catch the behaviour described in getsentry#464
7fc5fb0 to
5c86792
Compare
# Conflicts: # CHANGES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #464
mock up with custom
Falsethis allows to preserve deprecation warning and backwards compatibility with 0.16