Skip to content

IAM: add_user_to_group() should be idempotent#5899

Merged
bblommers merged 1 commit intogetmoto:masterfrom
bblommers:bug/iam-add-user-idempotency
Feb 3, 2023
Merged

IAM: add_user_to_group() should be idempotent#5899
bblommers merged 1 commit intogetmoto:masterfrom
bblommers:bug/iam-add-user-idempotency

Conversation

@bblommers
Copy link
Copy Markdown
Collaborator

Fixes #5897

@bblommers bblommers added this to the 4.1.2 milestone Feb 2, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2023

Codecov Report

Merging #5899 (ac6f1f5) into master (75059fd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5899   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         759      759           
  Lines       74768    74789   +21     
=======================================
+ Hits        71937    71958   +21     
  Misses       2831     2831           
Flag Coverage Δ
servertests 36.93% <0.00%> (-0.01%) ⬇️
unittests 96.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/iam/models.py 95.93% <100.00%> (+<0.01%) ⬆️
moto/glue/responses.py 99.68% <0.00%> (+<0.01%) ⬆️
moto/glue/models.py 97.13% <0.00%> (+0.03%) ⬆️
moto/awslambda/models.py 94.38% <0.00%> (+0.03%) ⬆️
moto/server.py 86.84% <0.00%> (+1.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bblommers bblommers merged commit 7d7663d into getmoto:master Feb 3, 2023
@bblommers bblommers deleted the bug/iam-add-user-idempotency branch February 3, 2023 12:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2023

This is now part of moto >= 4.1.2.dev22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IAM] Adding user the same IAM group twice causes the group to become "sticky"

1 participant