add connection type field to integration model#5867
Merged
bblommers merged 2 commits intogetmoto:masterfrom Jan 23, 2023
calvernaz:master
Merged
add connection type field to integration model#5867bblommers merged 2 commits intogetmoto:masterfrom calvernaz:master
bblommers merged 2 commits intogetmoto:masterfrom
calvernaz:master
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5867 +/- ##
==========================================
- Coverage 96.18% 96.17% -0.01%
==========================================
Files 757 757
Lines 74403 74405 +2
==========================================
- Hits 71563 71562 -1
- Misses 2840 2843 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bblommers
approved these changes
Jan 23, 2023
Collaborator
bblommers
left a comment
There was a problem hiding this comment.
LGTM - thanks for the PR @calvernaz!
Contributor
|
This is now part of moto >= 4.1.1.dev29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the connection type field to the integration model.
https://docs.aws.amazon.com/apigateway/latest/api/API_Integration.html