Skip to content

refactor(package_info_plus)!: two-package federated architecture#1236

Merged
nohli merged 4 commits into
mainfrom
unfederate-package-info-plus
Oct 14, 2022
Merged

refactor(package_info_plus)!: two-package federated architecture#1236
nohli merged 4 commits into
mainfrom
unfederate-package-info-plus

Conversation

@nohli

@nohli nohli commented Oct 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Refactor package_info_plus from the federated architecture to a platform interface and a package with all platform implementations.

Related Issues

#1226

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@nohli

nohli commented Oct 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Probably web tests requiring dart:html must be started with flutter test --platform chrome or this?
@miquelbeltran @vbuberen any idea?

@miquelbeltran

miquelbeltran commented Oct 13, 2022

Copy link
Copy Markdown
Member

Web tests were not running before either, so we can remove them, skip them, or renaming the file.

Integration tests for chrome are not enabled on the repo yet.

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 14, 2022
@miquelbeltran

miquelbeltran commented Oct 14, 2022

Copy link
Copy Markdown
Member

This seems to be good to merge, no?

@nohli

nohli commented Oct 14, 2022

Copy link
Copy Markdown
Member Author

Added _disabled at the end of the web test, which I don't find optimal, but it works now.

Why didn't these tests ran before (and without an error), as you mentioned?

@nohli nohli marked this pull request as ready for review October 14, 2022 14:12
@nohli nohli requested a review from vbuberen October 14, 2022 14:12
@miquelbeltran

miquelbeltran commented Oct 14, 2022

Copy link
Copy Markdown
Member

Added _disabled at the end of the web test, which I don't find optimal, but it works now.

Why didn't these tests ran before (and without an error), as you mentioned?

they were sitting in the web package and there was no CI job running them. I have no idea if they work or not 😬

@nohli nohli merged commit eccdc58 into main Oct 14, 2022
@nohli nohli deleted the unfederate-package-info-plus branch October 14, 2022 17:55
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@miquelbeltran miquelbeltran miquelbeltran approved these changes

@vbuberen vbuberen vbuberen approved these changes

Assignees

No one assigned

Labels

Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nohli @miquelbeltran @vbuberen