[spaceship] fix `fastlane init` and temporarily retrofitting `Spaceship::Tunes::Application.find` by joshdholtz · Pull Request #20480 · fastlane/fastlane

joshdholtz · 2022-07-19T02:47:14Z

Motivation and Context

Fixes undefined method `include?' for nil:NilClass (NoMethodError) #20444
Provides temporary work around for Spaceship::Tunes::Application.find
- Maybe fixes issue on App Center

Description

❌ The legacy Apple endpoint that Spaceship::Tunes::Application.find used is no longer available

This was not an issue for anything inside of fastlane (besides fastlane init still accidentally using it).

Fix 1 - `fastlane init`

This was the easy fix. setup_ios.rb now uses Spaceship::ConnectAPI::App.find instead. This uses the more stable Apple API now.

Fix 2 - Retrofit `Spaceship::Tunes::Application.find`

Because some users (and I think App Center) still want/need to use Spaceship::Tunes for in-app purchase things, I have done by best to retrofit Spaceship::Tunes:: Application.find by power it with Spaceship::ConnectAPI::App.find.

It's not a perfect fit because not all of the data is available but it will at least find the app and be able to give the app name, id and platforms.

Testing Steps

Update Gemfile and run bundle install, bundle update fastlane, or bundle update

gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "joshdholtz-fix-init"

Other Notes

‼️ IT IS STILL HIGHLY RECOMMEND TO USE STOP USING Spaceship::Tunes START USING Spaceship::ConnectAPI if you can

⚠️ However, there is not official Spaceship::ConnectAPI support for in-app purchases (yet) but I'm working on it. You can follow along with progress on this issue for now - #20477

fastlane-bot-helper · 2022-07-19T02:47:43Z

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

mjlaser · 2022-07-19T08:57:34Z

Regarding #20444 (comment).

That is all! So sorry about this taking so long. It ended up being a pretty back task to retrofit but I'm hoping it works out for some of you.

I am one of the users who is using the Tunes API for IAP uploads. Thanks for working on a fix to get us up and running again so quickly!

If any of you are able to test this PR / branch to make sure the retrofit is working for you that would be fire I need to go to bed now so I'll look at any response in the morning blush

I just tested your fix in our IAP automation project. It looks like things are working. Here are a subset of the API calls we are making. Let me know if you need more information to verify @joshdholtz.

client = Spaceship::Tunes.login(username, password)
client.select_team(team_id: team_id)
@app = Spaceship::Application.find(@app_id)
@app.in_app_purchases.create!(...)
@app.in_app_purchases.all.find { ... }

Looking forward to being able to use the ConnectAPI when it is available at some point in the future!

joshdholtz · 2022-07-19T09:00:27Z

@mjlaser Thank you for testing! BTW... do you mind dropping me an email at me AT joshholtz DOT com? 😊 I'd like to loop you into that early IAP testing if possible to make sure it works for you!

fastlane-bot

Congratulations! 🎉 This was released as part of fastlane 2.208.0 🚀

jafarlow · 2022-07-19T14:05:16Z

Thank you very much for putting this together! I can confirm I am now able to successfully distribute from App Center into App Store Connect like normal. 🙏 🎉

rafaelnobrekz · 2022-07-19T15:02:31Z

@joshdholtz The temporary solution for IAP management did the trick to unblock my pending bulk uploading, thanks! 👍
We use the following API:

spaceship = Spaceship::Tunes.login(apple_id)
spaceship.team_id = itc_team_id
app = Spaceship::Tunes::Application.find(app_identifier)
app.in_app_purchases.create!
app.in_app_purchases.all

sandy-boop · 2022-08-17T08:45:21Z

Regarding #20444 (comment).

That is all! So sorry about this taking so long. It ended up being a pretty back task to retrofit but I'm hoping it works out for some of you.

I am one of the users who is using the Tunes API for IAP uploads. Thanks for working on a fix to get us up and running again so quickly!

If any of you are able to test this PR / branch to make sure the retrofit is working for you that would be fire I need to go to bed now so I'll look at any response in the morning blush

I just tested your fix in our IAP automation project. It looks like things are working. Here are a subset of the API calls we are making. Let me know if you need more information to verify @joshdholtz.
client = Spaceship::Tunes.login(username, password)
client.select_team(team_id: team_id)
@app = Spaceship::Application.find(@app_id)
@app.in_app_purchases.create!(...)
@app.in_app_purchases.all.find { ... }
Looking forward to being able to use the ConnectAPI when it is available at some point in the future!

hello,Can you upload IAP now? I haven't succeeded here. I'll prompt undefined method ` in_ app_ purchases' for #Spaceship::ConnectAPI::App:0x00007facb1335f58 (NoMethodError)
my code
require 'spaceship'
Spaceship::ConnectAPI.login("h", "Wa3")
app = Spaceship::ConnectAPI::App.find("cw")

app.in_app_purchases.create!(
type: Spaceship::ConnectAPI::IAPType::CONSUMABLE,
versions: {
'zh-Hans': { name:"30b", description:"30a" },

wade0317 · 2022-12-12T08:25:05Z

create auto iap still failed now

joshdholtz changed the title ~~Commiting before i go crazy~~ [spaceship] temporary fix for Spaceship::Tunes::Application.find Jul 19, 2022

joshdholtz added 3 commits July 18, 2022 22:25

Commiting before i go crazy

aa25f18

This better hopefully

67c97e6

Fixed require

bbe1160

joshdholtz force-pushed the joshdholtz-fix-init branch from 847000c to bbe1160 Compare July 19, 2022 03:31

joshdholtz changed the title ~~[spaceship] temporary fix for Spaceship::Tunes::Application.find~~ [spaceship] fix fastlane init and temporary fix for Spaceship::Tunes::Application.find Jul 19, 2022

joshdholtz added 4 commits July 18, 2022 22:44

Test lint

0faef24

Lint this

eb7b5bc

Lint this

d7da807

All tests green please

5a5a01e

This was referenced Jul 19, 2022

App Store Distribution is broken microsoft/fastlane-plugin-appcenter#304

Closed

undefined method `include?' for nil:NilClass (NoMethodError) #20444

Closed

joshdholtz marked this pull request as ready for review July 19, 2022 04:23

Huge comment block

bc32ec7

joshdholtz changed the title ~~[spaceship] fix fastlane init and temporary fix for Spaceship::Tunes::Application.find~~ [spaceship] fix fastlane init and temporarily retrofitting Spaceship::Tunes::Application.find Jul 19, 2022

Adding a deprecation message in console

ca004af

joshdholtz merged commit 81275ea into master Jul 19, 2022

joshdholtz mentioned this pull request Jul 19, 2022

Version bump to 2.208.0 #20483

Merged

fastlane-bot added the status: released label Jul 19, 2022

fastlane-bot reviewed Jul 19, 2022

View reviewed changes

ralesiupgrade mentioned this pull request Jul 19, 2022

App Center distribute fails since 7/6/2022 microsoft/appcenter#2439

Closed

lexicalninja mentioned this pull request Jul 26, 2022

Unable to access analytics #20510

Open

4 tasks

phjs mentioned this pull request Nov 30, 2022

Create new app version fails #20904

Open

lacostej deleted the joshdholtz-fix-init branch November 24, 2023 14:13

This was referenced Jul 11, 2025

[Snyk] Security upgrade fastlane from 2.214.0 to 2.215.0 naiba4/ivy-wallet#9

Open

[Snyk] Fix for 2 vulnerabilities kingjay66/Signal-iOS#7

Open

[Snyk] Security upgrade fastlane from 2.214.0 to 2.215.0 naiba4/ivy-wallet#10

Open

socket-security Bot mentioned this pull request Sep 24, 2025

[Snyk] Fix for 1 vulnerabilities kingjay66/Signal-iOS#8

Open

This was referenced Oct 3, 2025

[Snyk] Security upgrade fastlane from 2.214.0 to 2.215.0 naiba4/ivy-wallet#11

Open

[Snyk] Fix for 1 vulnerabilities kingjay66/Signal-iOS#9

Open

socket-security Bot mentioned this pull request Dec 24, 2025

[Snyk] Fix for 1 vulnerabilities kingjay66/Signal-iOS#10

Open

github-actions Bot locked and limited conversation to collaborators Dec 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[spaceship] fix `fastlane init` and temporarily retrofitting `Spaceship::Tunes::Application.find`#20480

[spaceship] fix `fastlane init` and temporarily retrofitting `Spaceship::Tunes::Application.find`#20480
joshdholtz merged 9 commits intomasterfrom
joshdholtz-fix-init

joshdholtz commented Jul 19, 2022 •

edited

Loading

Uh oh!

fastlane-bot-helper commented Jul 19, 2022

Uh oh!

mjlaser commented Jul 19, 2022

Uh oh!

joshdholtz commented Jul 19, 2022

Uh oh!

fastlane-bot left a comment

Uh oh!

jafarlow commented Jul 19, 2022

Uh oh!

rafaelnobrekz commented Jul 19, 2022

Uh oh!

sandy-boop commented Aug 17, 2022

Uh oh!

wade0317 commented Dec 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

joshdholtz commented Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

Fix 1 - fastlane init

Fix 2 - Retrofit Spaceship::Tunes::Application.find

Testing Steps

Other Notes

Uh oh!

fastlane-bot-helper commented Jul 19, 2022

Uh oh!

mjlaser commented Jul 19, 2022

Uh oh!

joshdholtz commented Jul 19, 2022

Uh oh!

fastlane-bot left a comment

Choose a reason for hiding this comment

Uh oh!

jafarlow commented Jul 19, 2022

Uh oh!

rafaelnobrekz commented Jul 19, 2022

Uh oh!

sandy-boop commented Aug 17, 2022

Uh oh!

wade0317 commented Dec 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

joshdholtz commented Jul 19, 2022 •

edited

Loading

Fix 1 - `fastlane init`

Fix 2 - Retrofit `Spaceship::Tunes::Application.find`