[snapshot] use empty string to blank out operator name by default#20429
Merged
getaaron merged 2 commits intofastlane:masterfrom Jul 9, 2022
ZevEisenberg:patch-1
Merged
[snapshot] use empty string to blank out operator name by default#20429getaaron merged 2 commits intofastlane:masterfrom ZevEisenberg:patch-1
getaaron merged 2 commits intofastlane:masterfrom
ZevEisenberg:patch-1
Conversation
… override_status_bar_arguments to work.
Contributor
Author
|
Had some build flakiness, but I re-ran them a couple times and everything is passing now. |
getaaron
approved these changes
Jul 9, 2022
|
Hey @ZevEisenberg 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
|
Congratulations! 🎉 This was released as part of fastlane 2.208.0 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(made edits in the GitHub web UI; I'll check out the code and run these checks and update this)
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
If you don't pass
--operatorNametoxcrun simctl status_bar, it defaults to "Carrier". This change makes it blank instead, which matches Apple's marketing screenshots.Note: on some older simulators, it may be necessary to pass a zero-width space
\u200Dinstead of an empty string, but iOS 15.5 (and possibly earlier) seem to support an empty string to blank out the carrier.Description
Use an empty string explicitly instead of using the default. Tested locally with
xcrun simctlto verify the correct parameters.Testing Steps
Probably easier to just test with simctl. This will produce a good status bar (just the cellular section; leaving out the other parameters for brevity):
xcrun simctl status_bar booted override --operatorName "" --cellularMode activeWhereas this produces "Carrier" in the screenshot: