feat: add target parameter, make it major by default#47
Conversation
|
Although it's not enforced in this repo, let's try to stick to conventional commits when committing to this repo. Also stick to shorter commit messages as per git's guidelines (below 50 chars on the first line of the commit). Please rebase and squash commits to make it a single one which adheres to the above. |
|
Also please modify the workflow file to run linting and testing and make the automerge job depend on it. Inspire from https://github.com/nearform/get-jwks/blob/main/.github/workflows/ci.yml (no need for caching node_modules though). Note the syntax of the npm lint script looks wrong, I think it should be |
|
the ci workflow should also run on push, not just pull request. can you please make that change too? |
simoneb
left a comment
There was a problem hiding this comment.
LGTM, see inline comments
|
please rebase on main branch and resolve conflicts |
Closes #44
Checklist
npm run testandnpm run benchmarkand the Code of conduct