Skip to content

Restructure Parameters around Layered class#1045

Merged
jrapin merged 42 commits intofacebookresearch:masterfrom
jrapin:overridable
Feb 15, 2021
Merged

Restructure Parameters around Layered class#1045
jrapin merged 42 commits intofacebookresearch:masterfrom
jrapin:overridable

Conversation

@jrapin
Copy link
Copy Markdown
Contributor

@jrapin jrapin commented Feb 11, 2021

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 11, 2021
@jrapin jrapin mentioned this pull request Feb 12, 2021
7 tasks

def test_scalar_module() -> None:
ref = par.Scalar()
x = par.Scalar(10) % 4
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may help with circular parameters #759

@jrapin jrapin changed the title [WIP] Restructure Parameters around overridable [WIP] Restructure Parameters around Layered class Feb 12, 2021
@jrapin jrapin changed the title [WIP] Restructure Parameters around Layered class Restructure Parameters around Layered class Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. Difficulty: High Priority: Critical

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants