Conversation
jrapin
reviewed
Jan 8, 2021
Comment on lines
+203
to
+205
| index += 1 | ||
| if index % 5 != 0: | ||
| continue |
Contributor
There was a problem hiding this comment.
it feels really artificial :s I would rather this does not propagate too much :s
Contributor
Author
There was a problem hiding this comment.
I've shortened. I think the PR is useful: it reduces the computational cost by a vast margin.
jrapin
approved these changes
Apr 7, 2021
Contributor
jrapin
left a comment
There was a problem hiding this comment.
i don't quite like this index thing but ok for now, we'll probably need something better eventually though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
With the current code minimize was ok but not ask/tell, no idea why.
How Has This Been Tested (if it applies)
Checklist