Summary

Fixes #7884

For positive toHaveBeen*CalledWith assertions:

• Display matcher name in regular black instead of dim color
• Replace sentences with Expected and Received labels
• Display Number of calls at end of report
• Display received call arguments on one line separated by commas with dim color if value is equal to expected, except for the following special cases:

Display line diff for received call which corresponds to expected call number:

• not indented if only one received call
• indented if multiple received calls

Residue: replace line diff with data-driven diff formatted on one line, when it becomes available

@bandersongit These improvements build on recent pull requests:

• expect: Improve report when negative CalledWith assertion fails #8755 for negative toHaveBeen*CalledWith matchers
• expect: Improve report when mock-spy matcher fails, part 4 #8710 for toHave*ReturnedWith matchers
• expect: Improve report when mock-spy matcher fails, part 2 #8649 for simpler mock-spy matchers

Read the following descriptions with the qualifier if they exist:

Questions

• What do you think about comma following argument when report contains line diff?
• Is dim color relevant to toHave*Returned matchers when received value is equal to expected?

Faithful reviewers, this is last in series of basic improvements to all matchers! Thank you ❤️

Test plan

Updated 34 snapshots

See also pictures in following comments

Example pictures baseline at left and improved at right