Skip to content

expect: Improve report when mock-spy matcher fails, part 1#8640

Merged
pedrottimark merged 2 commits intojestjs:masterfrom
pedrottimark:improve-mock-spy-1
Jul 4, 2019
Merged

expect: Improve report when mock-spy matcher fails, part 1#8640
pedrottimark merged 2 commits intojestjs:masterfrom
pedrottimark:improve-mock-spy-1

Conversation

@pedrottimark
Copy link
Copy Markdown
Contributor

@pedrottimark pedrottimark commented Jul 3, 2019

Summary

Improve Matcher error reports for all 20 mock-spy matchers

Indentation changed in spyMatchers.ts because of function to access this: MatcherState but the actual changes are limited to:

  • declare expectedArgument and options
  • edit arguments in ensureNoExpected calls
  • edit arguments in ensureExpectedIsNumber calls
  • edit arguments in ensureMock calls
  • rewrite ensureMock function

The matcherName.slice(1) is temporary to omit . in matcher error snapshots only

Future pull requests in this series will remove . from matcher names in create function calls

Breaking Residue for Jest 25

  • Distinguish ensureMock from ensureMockOrSpy because Jasmine spy does not store return values, true?
  • Replace ensureExpectedIsNumber with ensureExpectedIsNonNegativeInteger
  • Write ensureNthIsPositiveInteger function which verifies safe integer and does not call parseInt

Test plan

Updated 76 snapshots

matcher change to test
1 lastCalledWith
1 lastReturnedWith
1 nthCalledWith
1 nthReturnedWith
3 toBeCalled
13 toBeCalledTimes .not works only on spies or jest.fn
1 toBeCalledWith
3 toHaveBeenCalled
13 toHaveBeenCalledTimes .not works only on spies or jest.fn
1 toHaveBeenCalledWith
1 toHaveBeenLastCalledWith
1 toHaveBeenNthCalledWith
1 toHaveLastReturnedWith
1 toHaveNthReturnedWith
3 toHaveReturned .not works only on jest.fn
13 toHaveReturnedTimes
1 toHaveReturnedWith
3 toReturn .not works only on jest.fn
13 toReturnTimes
1 toReturnWith

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 3, 2019 •
edited
Loading

Codecov Report

Merging #8640 into master will increase coverage by 0.09%.
The diff coverage is 88.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8640      +/-   ##
==========================================
+ Coverage    63.4%   63.49%   +0.09%     
==========================================
  Files         274      274              
  Lines       11342    11372      +30     
  Branches     2770     2770              
==========================================
+ Hits         7191     7221      +30     
  Misses       3534     3534              
  Partials      617      617
Impacted Files Coverage Δ
packages/expect/src/spyMatchers.ts 89.02% <88.39%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b64bb4...e838f78. Read the comment docs.

@pedrottimark pedrottimark merged commit b64d35d into jestjs:master Jul 4, 2019
@pedrottimark pedrottimark deleted the improve-mock-spy-1 branch July 4, 2019 19:50
@snyk-bot snyk-bot mentioned this pull request Sep 2, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
This was referenced Dec 31, 2019
Open
Open
This was referenced Jan 7, 2020
Open
Open
Open
Open
This was referenced Jan 21, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 30, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Jul 17, 2020
Open
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

@thymikee thymikee Awaiting requested review from thymikee

@jeysal jeysal Awaiting requested review from jeysal

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pedrottimark @codecov-io @SimenB @facebook-github-bot