Allow the cli to use a string for --maxWorkers#8565
Allow the cli to use a string for --maxWorkers#8565SimenB merged 6 commits intojestjs:masterfrom philiiiiiipp:fix_maxWorkers_cli
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #8565 +/- ##
==========================================
- Coverage 63.2% 63.18% -0.03%
==========================================
Files 271 271
Lines 11284 11296 +12
Branches 2749 2754 +5
==========================================
+ Hits 7132 7137 +5
- Misses 3538 3544 +6
- Partials 614 615 +1
Continue to review full report at Codecov.
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
jeysal
left a comment
There was a problem hiding this comment.
Cool, thanks! Kind of uncomfortable not having an integration test for this but at least yargs is pretty declarative so it might be hard to break it in this place again
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #8559 and allows --maxWorkers 20% to be used again.
Test plan
I did add tests and added an example to the cli output, however testing the args in specific is one level higher and would require more thought.