chore: bump typescript to v4.7#12901
Merged
SimenB merged 5 commits intojestjs:mainfrom Jun 3, 2022
mrazauskas:chore-ts4.7
Merged
chore: bump typescript to v4.7#12901SimenB merged 5 commits intojestjs:mainfrom mrazauskas:chore-ts4.7
typescript to v4.7#12901SimenB merged 5 commits intojestjs:mainfrom
mrazauskas:chore-ts4.7
Conversation
Member
|
need to update some lockfiles |
SimenB
approved these changes
Jun 3, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12877
Summary
This should fix TypeScript upgrade issue. Interesting thing was caught by TS. For example, this:
Will throw: "Error: Cannot spy the ups property because it is not a function".
But here:
It throws: "TypeError: Cannot convert a Symbol value to a string". This is what TS was suggesting to fix. After this fix, the error message becomes: "Error: Cannot spy the Symbol(ups) property because it is not a function". Much better.
Also I spend some time trying out if
jest.spyOnaccepts keys as symbols. It does, all works. Only error messages is the issue. Would be nice to have tests for these, of course. Started working, refactoring some details and here I got stuck ;D Wait.. But that is another story already. Better I will make separate PR later.Test plan
Green CI.