Skip to content

fix(expect): add missing dependency jest-util#12744

Merged
SimenB merged 5 commits intojestjs:mainfrom
merceyz:merceyz/fix/expect-missing-dep
Apr 26, 2022
Merged

fix(expect): add missing dependency jest-util#12744
SimenB merged 5 commits intojestjs:mainfrom
merceyz:merceyz/fix/expect-missing-dep

Conversation

@merceyz
Copy link
Copy Markdown
Contributor

@merceyz merceyz commented Apr 25, 2022

Summary

expect depends on jest-util but doesn't declare it as a dependency.
https://github.com/facebook/jest/blob/045367ad9ca773536a73efdfad019eeb2778ee32/packages/expect/src/asymmetricMatchers.ts#L16

Fixes https://github.com/yarnpkg/berry/runs/6157024113?check_suite_focus=true#step:4:44

Test plan

yarn init -2
yarn add jest@^28
  
echo "it('should pass', () => { expect(true).toBeTruthy(); });" | tee pass.test.js
yarn jest pass.test.js

@merceyz merceyz force-pushed the merceyz/fix/expect-missing-dep branch from a31b31b to aceeaba Compare April 25, 2022 20:03
@merceyz merceyz force-pushed the merceyz/fix/expect-missing-dep branch from aceeaba to c437289 Compare April 25, 2022 20:03
@SimenB
Copy link
Copy Markdown
Member

SimenB commented Apr 25, 2022 •
edited
Loading

Good catch! Mind updating tsconfig.json as well?

EDIT: hah, good timing 😅

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Apr 26, 2022

@merceyz any idea why it's failing? It's the PnP test

@merceyz
Copy link
Copy Markdown
Contributor Author

merceyz commented Apr 26, 2022 •
edited
Loading

Looks like an issue with the npm registry, you can try re-running the failed workflow.

SimenB
SimenB approved these changes Apr 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 9fc3ba4 into jestjs:main Apr 26, 2022
@merceyz merceyz deleted the merceyz/fix/expect-missing-dep branch April 26, 2022 09:59
@SimenB
Copy link
Copy Markdown
Member

SimenB commented Apr 26, 2022

https://github.com/facebook/jest/releases/tag/v28.0.1

F3n67u pushed a commit to F3n67u/jest that referenced this pull request May 2, 2022
@merceyz @F3n67u
fix(expect): add missing dependency jest-util (jestjs#12744)
479fa11
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@merceyz @SimenB @facebook-github-bot