feat(jest-core, jest-watcher)!: move TestWatcher class to jest-watcher#12652
Merged
SimenB merged 4 commits intojestjs:mainfrom Apr 8, 2022
mrazauskas:feat!-move-TestWatcher
Merged
feat(jest-core, jest-watcher)!: move TestWatcher class to jest-watcher#12652SimenB merged 4 commits intojestjs:mainfrom mrazauskas:feat!-move-TestWatcher
TestWatcher class to jest-watcher#12652SimenB merged 4 commits intojestjs:mainfrom
mrazauskas:feat!-move-TestWatcher
Conversation
mrazauskas
commented
Apr 8, 2022
SimenB
reviewed
Apr 8, 2022
| * | ||
| */ | ||
|
|
||
| import {TestWatcher} from '@jest/core'; |
Member
There was a problem hiding this comment.
do we still need the dep on @jest/core?
Contributor
Author
There was a problem hiding this comment.
Seems like jest-runner did not list it as a dependency 🤷♂️
mrazauskas
commented
Apr 8, 2022
This reverts commit eb199bd.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As a TODO comment in
jest-runnermentioned, it seems to be good idea to moveTestWatcherclass tojest-watcher. Noticed it while working on #12646 and just could not leave it.Test plan
Green CI.