feat: introduce new @jest/expect-utils package#12323
Merged
SimenB merged 1 commit intojestjs:mainfrom Feb 9, 2022
Merged
Conversation
|
Wow lots of changes for a seemingly simple ask, thank you! |
Codecov Report
@@ Coverage Diff @@
## main #12323 +/- ##
==========================================
- Coverage 67.25% 67.00% -0.26%
==========================================
Files 330 330
Lines 17354 17352 -2
Branches 5073 5072 -1
==========================================
- Hits 11671 11626 -45
- Misses 5651 5694 +43
Partials 32 32
Continue to review full report at Codecov.
|
0e09149 to
322395d
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11867.
We also need to figure out how to expose
build/matchers, but that also ties into adding custom TS matchers. Not 100% sure how to deal with that?Also, far from all utils need to be exposed in this way, we should cull the API surface.
EDIT: Hmm, would it be better to just add all this to
jest-matcher-utils?Test plan
Green CI