feat(jest-haste-map): support dependencyExtractor written in ESM#12008
Merged
SimenB merged 9 commits intojestjs:mainfrom Feb 24, 2022
Merged
feat(jest-haste-map): support dependencyExtractor written in ESM#12008SimenB merged 9 commits intojestjs:mainfrom
dependencyExtractor written in ESM#12008SimenB merged 9 commits intojestjs:mainfrom
Conversation
chentsulin
commented
Oct 28, 2021
chentsulin
commented
Oct 28, 2021
5c21bae to
db74246
Compare
SimenB
reviewed
Oct 28, 2021
| } | ||
|
|
||
| static create(options: Options): HasteMap { | ||
| static async create(options: Options): Promise<HasteMap> { |
Member
There was a problem hiding this comment.
code in general looks good, but this makes it a breaking change and must wait for Jest 28 🙂 I'll add it to the milestone so we don't forget
16 tasks
8cce621 to
f59420e
Compare
chentsulin
commented
Oct 28, 2021
| 'a.js': 'module.exports = {foo: 5};', | ||
| 'dependencyExtractor.mjs': ` | ||
| const DYNAMIC_IMPORT_RE = /(?:^|[^.]\\s*)(\\bdynamicImport\\s*?\\(\\s*?)([\`'"])([^\`'"]+)(\\2\\s*?\\))/g; | ||
| export function extract(code, filePath) { |
Contributor
Author
There was a problem hiding this comment.
I am not quite sure we should accept extract named export or a default export here.
named export:
export function extract(code, filePath) {
const dependencies = new Set();
if (filePath.includes('skip-deps')) {
return dependencies;
}
const addDependency = (match, pre, quot, dep, post) => {
dependencies.add(dep);
return match;
};
code.replace(DYNAMIC_IMPORT_RE, addDependency);
return dependencies;
};default export:
export default {
extract(code, filePath) {
const dependencies = new Set();
if (filePath.includes('skip-deps')) {
return dependencies;
}
const addDependency = (match, pre, quot, dep, post) => {
dependencies.add(dep);
return match;
};
code.replace(DYNAMIC_IMPORT_RE, addDependency);
return dependencies;
}
}
chentsulin
commented
Oct 28, 2021
chentsulin
commented
Oct 29, 2021
2030f21 to
7c30268
Compare
Member
|
Hey! I've started to land breaking changes, so if you rebase this we can see where we're at? 🙂 |
7c30268 to
08e4923
Compare
Contributor
Author
|
Ok. I've done the rebase. |
Member
|
Awesome, thanks! I think I've commented on the two open questions? |
e9abd9f to
e2325bc
Compare
e2325bc to
6a57b81
Compare
SimenB
reviewed
Feb 23, 2022
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
e4de85a to
55cd8e1
Compare
chentsulin
commented
Feb 23, 2022
| expect(stderr).toMatch(summaryMsg); | ||
| }); | ||
|
|
||
| test('runs tests related to filename with a custom dependency extractor written in ESM', () => { |
Contributor
Author
There was a problem hiding this comment.
@SimenB I am not sure if this is a valid e2e test of ESM dependency extractor. I just found a commonjs version above and did the same against ESM.
SimenB
reviewed
Feb 24, 2022
dependencyExtractor written in ESM
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #11167.
See the discussion on the
dependencyExtractorconfig: #11167 (comment)Test plan
new HasteMap(...)calls toawait HasteMap.create(...)Runtime.createHasteMap(...)calls toawait Runtime.createHasteMap(...)