fix: resolve bundled modules from correct location#11493
fix: resolve bundled modules from correct location#11493SimenB merged 2 commits intojestjs:masterfrom
Conversation
|
@merceyz sorry to ping you, but do you have any tips for how to make the script I added as a "test" work? Using just Using |
Codecov Report
@@ Coverage Diff @@
## master #11493 +/- ##
==========================================
- Coverage 68.95% 68.94% -0.02%
==========================================
Files 312 312
Lines 16310 16314 +4
Branches 4722 4726 +4
==========================================
Hits 11247 11247
- Misses 5035 5039 +4
Partials 28 28
Continue to review full report at Codecov.
|
d007a65 to
c94ec5d
Compare
|
Moved test to #11513 |
|
@SimenB No worries, responded in #11513 (comment) |
|
Instead of passing the require function around, wouldn't passing the filepath instead be better? |
|
Passing in |
|
Depends on where it should be resolved relative to, but yeah |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Take 2 at fixing #11452. This time by passing in
require.resolvefrom the modules that do therequireso that it looks like it's e.g.jest-configdoing therequire.resolverather thanjest-resolve, thus satisfying the dependencyTest plan
🤷