refactor(fake-timers): don't setup fakeTimerAPIs unless needed#10551
Merged
SimenB merged 4 commits intojestjs:masterfrom Oct 19, 2020
Merged
Conversation
SimenB
approved these changes
Sep 27, 2020
Member
SimenB
left a comment
There was a problem hiding this comment.
Thanks! Mind adding a changelog entry?
This was referenced Mar 13, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Noticed that the mock fn's for the legacy fake timers are created immediately, even if they're never used. Since
_createMocksis called inuseFakeTimers, it seems we should be able to remove this from the constructor and only set them up if needed.Test plan
No functional change, existing tests should pass