Skip to content

Fix lifecycle hook function types#10480

Merged
SimenB merged 1 commit intojestjs:masterfrom
villasv:fix-10066
Sep 8, 2020
Merged

Fix lifecycle hook function types#10480
SimenB merged 1 commit intojestjs:masterfrom
villasv:fix-10066

Conversation

@villasv
Copy link
Copy Markdown
Contributor

@villasv villasv commented Sep 4, 2020 •
edited
Loading

Summary

Fixes #10066

Test plan

Added a new type test suite for the @jest/globals to ensure lifecycle hooks are not typed as HookFn that could return Promise, but are at least functions that return void.

@jeysal jeysal requested a review from SimenB September 7, 2020 20:14
@SimenB
Copy link
Copy Markdown
Member

SimenB commented Sep 7, 2020

Ideally this'd include type tests (based on #10407), but we don't have any tests for these globals, so possibly out of scope?

@villasv
Copy link
Copy Markdown
Contributor Author

villasv commented Sep 8, 2020 •
edited
Loading

Added a new test file for the globals. The test successfully fails™ before the suggested changes, but is now passing.

It doesn't test exactly what I wanted (I wanted to test the argument types, it's testing the function return types), but it does the job.

SimenB
SimenB approved these changes Sep 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks! Could you update the changelog as well?

@villasv
Copy link
Copy Markdown
Contributor Author

villasv commented Sep 8, 2020

Wasn't sure where to put it, left it on the master's Fixes section.

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Sep 8, 2020

Wasn't sure where to put it, left it on the master's Fixes section.

Exactly right 👍

@SimenB SimenB merged commit ec75280 into jestjs:master Sep 8, 2020
@villasv villasv deleted the fix-10066 branch September 9, 2020 12:08
@villasv villasv mentioned this pull request Sep 17, 2020
Closed
@villasv villasv mentioned this pull request Nov 16, 2020
Merged
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

@jeysal jeysal jeysal approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect types for lifecycle functions

4 participants

@villasv @SimenB @jeysal @facebook-github-bot