Skip to content

Make validators and sanitizers run in the order they are specified#722

Merged
gustavohenke merged 37 commits intomasterfrom
context-stack
Jun 14, 2019
Merged

Make validators and sanitizers run in the order they are specified#722
gustavohenke merged 37 commits intomasterfrom
context-stack

Conversation

@gustavohenke
Copy link
Copy Markdown
Member

@gustavohenke gustavohenke commented Jun 14, 2019

This a breaking change from previous versions.

Take this sample validation chain:

check('foo')
  .isEmail()
  .escape()
  .custom(isEmailInDatabase)

How it used to be: escape runs first, then isEmail, then the custom validator. Sanitizers would always run first (in the order they are specified among them), then validators (in the order they are specified among them).

How it will be from now on: isEmail runs first, then escape, then the custom validator. The validators or sanitizers will run in the order they are specified.

This architecture is now called "context stack", which allows us to better implement things like #500 or maybe even #658.

gustavohenke added 30 commits June 1, 2019 17:01
@gustavohenke
Create ContextItem interfaces
644f4d6
@gustavohenke
context: change everything :P
b5f04d4
@gustavohenke
context-item: implement sanitization and validation
ef3a249
@gustavohenke
select-fields: move it outside context-runners
aa9cc45
@gustavohenke
context-runners: remove them
fc500ae
@gustavohenke
context: move sanitization and validation responsibilities out
60fccd9
@gustavohenke
chain: use Context#addItem() API
fec25ac
@gustavohenke
chain: use Context#addItem() API
e50759e
@gustavohenke
chain/context-handler: read Context#stack instead of #validations
0500727
@gustavohenke
context: return array from #getData()
836c864
@gustavohenke
chain: create ContextRunner interface and implementation
28db199
@gustavohenke
middlewares/check: use ContextRunner instead of self-contained logic
3986093
@gustavohenke
select-fields: export function type definition
24973ac
@gustavohenke
chain: export ContextRunner from the barrel file
9d3ae89
@gustavohenke
middlewares/check: remove useless comment and import
cdf0440
@gustavohenke
middleware/sanitize: use ContextRunner instead of self-contained logic
82f9e80
@gustavohenke
middlewares/one-of: rewrite to make use of new Context API
c9e5bff
@gustavohenke
context: overload addError to work with oneOf()
4dbfa2a
@gustavohenke
context: store fields and locations as some sort of "meta"
a0b5fb8
@gustavohenke
chain: make validation and sanitization extend ContextRunner
a964e03
@gustavohenke
middlewares: make oneOf pass locations/fields to its surrogate context
020eefb
@gustavohenke
middlewares/schema: refactor tests to work with new context
58c4ed8
@gustavohenke
matched-data: refactor to work with new context
d7a8d34
@gustavohenke
context-items: read negated flag from context instead of ctor arg
9a2f2fe
@gustavohenke
chain: read fields and locations from context
c983f0e
@gustavohenke
middlewares: fix validation chain builders tests
0646031
@gustavohenke
context-items/sanitization: invert comparisons
43416bf
@gustavohenke
context-items: test CustomValidation
1e83611
@gustavohenke
context-items: test StandardValidation
971e6fb
@gustavohenke
context-items: test Sanitization
72b99d8
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 14, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 5b06277 on context-stack into 5dbc6dc on master.

@gustavohenke gustavohenke marked this pull request as ready for review June 14, 2019 12:33
@gustavohenke gustavohenke merged commit 0d71a79 into master Jun 14, 2019
@gustavohenke gustavohenke deleted the context-stack branch June 14, 2019 23:44
@lock
Copy link
Copy Markdown

lock bot commented Aug 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gustavohenke @coveralls