Skip to content

Add .bail() functionality.#500

Closed
neobyteUK wants to merge 1 commit intoexpress-validator:masterfrom
neobyteUK:master
Closed

Add .bail() functionality.#500
neobyteUK wants to merge 1 commit intoexpress-validator:masterfrom
neobyteUK:master

Conversation

@neobyteUK
Copy link
Copy Markdown

@neobyteUK neobyteUK commented Jan 20, 2018 •
edited
Loading

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6a329a8 on neobyteUK:master into 3c0ff85 on express-validator:master.

gustavohenke
gustavohenke reviewed Jan 21, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation and tests look good 👍

I'm not sure about what should happen to multi field validation chains, egcheck(['foo', 'bar']) or check('foo.*').
Do you think that the proposed behaviour is good enough?

Also, can you please add docs?
Thanks in advance!

@neobyteUK
Copy link
Copy Markdown
Author

neobyteUK commented Jan 22, 2018

There is an update in the readme, do you mean more than that?

As for the multi-field questions, I will have a look at it but won't have time till this weekend.

@gustavohenke
Copy link
Copy Markdown
Member

gustavohenke commented Jan 28, 2018

There is an update in the readme, do you mean more than that?

Yes, like an API doc, not just an example.

@gustavohenke gustavohenke mentioned this pull request Feb 5, 2018
Closed
@gustavohenke gustavohenke mentioned this pull request Sep 8, 2018
Closed
@G-Rath
Copy link
Copy Markdown

G-Rath commented Dec 7, 2018

Any update on this? could really use this feature :/

@gustavohenke gustavohenke mentioned this pull request Dec 11, 2018
Closed
@erandagan
Copy link
Copy Markdown

erandagan commented Dec 24, 2018

Hey @gustavohenke, is there any way to help to get this merged and released? This is a really useful feature. If any changes / testing are required I'll be happy to help.

@chrisspiegl
Copy link
Copy Markdown

chrisspiegl commented Feb 10, 2019

I'm very much hoping for this to be added. I recently tried doing things like this again but found no alternative.
I'm looking forward to seeing an update.

@neobyteUK
Add .bail() functionality.
6a329a8 
* Allow validation to return after first validator in chain fails.
@neobyteUK
Copy link
Copy Markdown
Author

neobyteUK commented Mar 30, 2019

I've brushed the cobwebs off rebased and updated the documentation for this.

@michalczaplinski
Copy link
Copy Markdown

michalczaplinski commented Apr 14, 2019

@gustavohenke Hey, any chance of getting this merged? It seems like a great usability improvement.
Kudos for the the PR @neobyteUK! 👌

@G-Rath
Copy link
Copy Markdown

G-Rath commented May 31, 2019 •
edited
Loading

@gustavohenke

Any update on this? The associated issue just got locked by lock-bot.

I'd be willing to take a crack at rebasing the PR, if that's the only thing needed for merging.

@gustavohenke gustavohenke mentioned this pull request Jun 14, 2019
Merged
@emauricio emauricio mentioned this pull request Jul 29, 2019
Closed
@gustavohenke gustavohenke mentioned this pull request Jul 29, 2019
Merged
@gustavohenke
Copy link
Copy Markdown
Member

gustavohenke commented Jul 29, 2019

Hello everyone,
Since the codebase changed a lot since this PR was opened, here's a new one: #751

gustavohenke added a commit that referenced this pull request Aug 16, 2019
@gustavohenke
Implement .bail() (#751)
d072629 
Closes #500, closes #638
@gustavohenke
Copy link
Copy Markdown
Member

gustavohenke commented Aug 30, 2019

Hey all! This is out with v6.2.0! 🚢

This was referenced Sep 8, 2019
Closed
Closed
@lock
Copy link
Copy Markdown

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gustavohenke gustavohenke gustavohenke left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@neobyteUK @coveralls @gustavohenke @G-Rath @erandagan @chrisspiegl @michalczaplinski