Skip to content

🐛 FIX: floor table column widths to integers#568

Merged
chrisjsewell merged 2 commits intoexecutablebooks:masterfrom
jeanas:info-table
May 15, 2022
Merged

🐛 FIX: floor table column widths to integers#568
chrisjsewell merged 2 commits intoexecutablebooks:masterfrom
jeanas:info-table

Conversation

@jeanas
Copy link
Copy Markdown
Contributor

@jeanas jeanas commented May 14, 2022

Don't use floats, since some Sphinx builders expect the widths to be
integers, like the Texinfo builder and the text builder.

Closes #540

@welcome
Copy link
Copy Markdown

welcome bot commented May 14, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@jeanas
Round column widths to integers
056ab4d 
Don't use floats, since some Sphinx builders expect the widths to be
integers, like the Texinfo builder and the text builder.

Closes #540
@codecov
Copy link
Copy Markdown

codecov bot commented May 14, 2022 •
edited
Loading

Codecov Report

Merging #568 (b575490) into master (602470e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          20       20           
  Lines        2116     2116           
=======================================
  Hits         1901     1901           
  Misses        215      215
Flag Coverage Δ
pytests 89.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/mdit_to_docutils/base.py 92.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602470e...b575490. Read the comment docs.

chrisjsewell
chrisjsewell approved these changes May 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cheers!

@chrisjsewell chrisjsewell changed the title Round column widths to integers 🐛 FIX: Round table column widths to integers May 15, 2022
@chrisjsewell chrisjsewell changed the title 🐛 FIX: Round table column widths to integers 🐛 FIX: floor table column widths to integers May 15, 2022
@chrisjsewell chrisjsewell merged commit 3c45b7e into executablebooks:master May 15, 2022
@welcome
Copy link
Copy Markdown

welcome bot commented May 15, 2022

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@jeanas jeanas deleted the info-table branch May 15, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisjsewell chrisjsewell chrisjsewell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Markdown tables break texinfo builder because of float colspec

2 participants

@jeanas @chrisjsewell