🧪 TESTS: Fix regression output on 32-bit systems to match 64-bit systems#523
Merged
chrisjsewell merged 2 commits intoexecutablebooks:masterfrom Apr 13, 2022
Merged
🧪 TESTS: Fix regression output on 32-bit systems to match 64-bit systems#523chrisjsewell merged 2 commits intoexecutablebooks:masterfrom
chrisjsewell merged 2 commits intoexecutablebooks:masterfrom
Conversation
Fixes test_sphinx_directives[35-highlight (sphinx.directives.code.Highlight):] which was failing on 32-bit platforms due to linenothreshold defaulting to sys.maxsize. Fixes: executablebooks#522
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 16 16
Lines 2104 2104
=======================================
Hits 1889 1889
Misses 215 215
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Congrats on your first merged pull request in this project! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
test_sphinx_directives[35-highlight (sphinx.directives.code.Highlight):]which was failing on 32-bit platforms due tolinenothresholddefaulting tosys.maxsize.Fixes: #522