🐛 FIX: Front matter -> sphinx metadata regression#480
Merged
chrisjsewell merged 1 commit intomasterfrom Dec 29, 2021
Merged
Conversation
After #477, I noted that the `SmartQuote` transform was being applied to the front-matter values, before they were extracted to the document metadata. Therefore, we now add them as a `literal` to stop this happening.
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
=======================================
Coverage 90.02% 90.02%
=======================================
Files 16 16
Lines 2056 2056
=======================================
Hits 1851 1851
Misses 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR #477, I noted that the
SmartQuotetransform was being applied to the front-matter values,before they were extracted to the document metadata (see also issue #479).
Therefore, we now add them as a
literalto stop this happening.