Fix: support Async iteration (fixes #9891)#9957
Merged
not-an-aardvark merged 6 commits intomasterfrom Feb 10, 2018
Merged
Conversation
Member
I had that on the list because there were some problems with the |
Member
Author
|
I got it. I have missed the issue. |
ilyavolodin
approved these changes
Feb 8, 2018
gyandeeps
approved these changes
Feb 8, 2018
platinumazure
approved these changes
Feb 8, 2018
Member
|
Thanks for contributing! |
This was referenced Mar 8, 2018
This was referenced Mar 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
Fixes #9891.
What changes did you make? (Give an overview)
This PR fixes false positive and wrongly autofix about async iteration.
keyword-spacingrule to check the spacing betweenawaitand(infor-await-ofloops.no-await-in-looprule to not report await expressions onfor-await-ofloops and to reportfor-await-ofloops as same as await expressions.object-shorthandrule to fix async generators correctly.require-awaitrule to handlefor-await-ofloops as same as await expressions.generator-star-spacingrule for async generators.no-useless-computed-keyrule for async generators.Is there anything you'd like reviewers to focus on?
Are there other rules which need a fix?
I have searched by some node types in rules:
ForOfStatement,AwaitExpression,Property, andMethodDefinition.@not-an-aardvark I'm not sure about
semirule (#9891 (comment)). Thesemirule addresses at the end of statements, so it doesn't look to be related to theawaitkeyword in the middle of statements.