Fix: Typo in error message when running npm#9866
Merged
platinumazure merged 1 commit intoeslint:masterfrom Feb 2, 2018
Merged
Conversation
|
|
ilyavolodin
approved these changes
Jan 20, 2018
not-an-aardvark
suggested changes
Jan 20, 2018
Member
not-an-aardvark
left a comment
There was a problem hiding this comment.
Thanks for the PR, but I think the original version is grammatically correct and the new version is grammatically incorrect.
- The noun "package manager" needs an article or determiner before it (such as "your").
- "of choice" idiom.
Contributor
Author
|
Thank you for valuable comment. |
Member
|
@maciej-ka Thanks for the PR! I'd be okay with "a package manager of your choice", but I also don't see a strong need for this change. It's a little awkward as is, sure, but this doesn't seem like a significant improvement either. |
f4cbf88 to
0415206
Compare
not-an-aardvark
approved these changes
Feb 2, 2018
Member
not-an-aardvark
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
platinumazure
approved these changes
Feb 2, 2018
This was referenced Mar 8, 2018
This was referenced Mar 16, 2018
This was referenced Mar 19, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Updated an error message
Is there anything you'd like reviewers to focus on?
No