Chore: refactor populating configs with defaults in linter#10006
Merged
not-an-aardvark merged 1 commit intomasterfrom Feb 24, 2018
Merged
Chore: refactor populating configs with defaults in linter#10006not-an-aardvark merged 1 commit intomasterfrom
not-an-aardvark merged 1 commit intomasterfrom
Conversation
ilyavolodin
approved these changes
Feb 24, 2018
This was referenced Mar 2, 2018
This was referenced Mar 16, 2018
This was referenced Mar 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This refactors some of the config-handling logic in
linterto be simpler and avoid mutating its arguments.I'm working on generally cleaning up this code as part of implementing #9998.
Is there anything you'd like reviewers to focus on?
Nothing in particular