Skip to content

Enhancement: Update phpstan/phpstan and friends#281

Merged
localheinz merged 2 commits intomasterfrom
feature/phpstan
Dec 22, 2019
Merged

Enhancement: Update phpstan/phpstan and friends#281
localheinz merged 2 commits intomasterfrom
feature/phpstan

Conversation

@localheinz
Copy link
Copy Markdown
Member

@localheinz localheinz commented Dec 22, 2019

This PR

  • updates phpstan/phpstan and friends
  • fixes issues reported via static analysis

@localheinz localheinz self-assigned this Dec 22, 2019
@localheinz localheinz marked this pull request as ready for review December 22, 2019 15:19
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2019

Codecov Report

Merging #281 into master will decrease coverage by 1.24%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #281      +/-   ##
============================================
- Coverage     86.18%   84.94%   -1.25%     
- Complexity       35       37       +2     
============================================
  Files             2        3       +1     
  Lines           181      186       +5     
============================================
+ Hits            156      158       +2     
- Misses           25       28       +3
Impacted Files Coverage Δ Complexity Δ
src/Exception/ShouldNotHappen.php 0% <0%> (ø) 1 <1> (?)
src/Command/NormalizeCommand.php 86.62% <75%> (-0.36%) 33 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523deef...a6aec00. Read the comment docs.

@localheinz localheinz merged commit 43cf9f6 into master Dec 22, 2019
@localheinz localheinz deleted the feature/phpstan branch December 22, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant