[BUGFIX beta] Migrate autorun microtask queue to Promise.then#17618
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Feb 20, 2019
Merged
[BUGFIX beta] Migrate autorun microtask queue to Promise.then#17618rwjblue merged 1 commit intoemberjs:masterfrom
rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
The primary change in Backburner.js is to use the Promise microtask queue primarily and falling back to MutationObserver when Promise is not present. The test changes here are to migrate from `window.onerror` to `window.onunhandledrejection` hooks (due to moving the microtask delivery from `MutationObserver` to native `Promise`). The cross platform support for `onunhandledrejection` is a tad spotty (Chrome, Edge, and _soon_ Firefox), so I had to guard in other browsers.
0444e7d to
5596d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary change in backburner.js@2.5.0 is to use the Promise microtask queue primarily and falling back to MutationObserver when Promise is not present.
The test changes here are to migrate from
window.onerrortowindow.onunhandledrejectionhooks (due to moving the microtask delivery fromMutationObserverto nativePromise). The cross platform support foronunhandledrejectionis a tad spotty (Chrome, Edge, and soon Firefox), so I had to guard in other browsers.