Conversation
krisselden
approved these changes
Aug 23, 2018
Contributor
krisselden
left a comment
There was a problem hiding this comment.
looks good, I think we should move Opaque to unknown but that can be separate, also, anything that uses any | undefined | null should be {} | undefined | null or object | undefined | null as any is now really any,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades
broccoli-typescript-compilerto 4.0.1, which also upgrades the version of TypeScript to 3.0.There was only one small breaking change, which is that TypeScript 2.9 changed
keyoftypes to now include numbers and symbols in addition to strings. I updated these call signatures to extract just keys of typestringto maintain the previous behavior.