Skip to content

fix: <webview> not working with Trusted Types#27466

Merged
codebytere merged 1 commit into9-x-yfrom
trop/9-x-y-bp-fix-webview-not-working-with-trusted-types-1611538197763
Jan 25, 2021
Merged

fix: <webview> not working with Trusted Types#27466
codebytere merged 1 commit into9-x-yfrom
trop/9-x-y-bp-fix-webview-not-working-with-trusted-types-1611538197763

Conversation

@trop
Copy link
Copy Markdown
Contributor

@trop trop Bot commented Jan 25, 2021

Backport of #27445

See that PR for details.

Notes: Fixed <webview> not working with Trusted Types.

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jan 25, 2021
@trop trop Bot requested a review from miniak January 25, 2021 01:30
@trop trop Bot mentioned this pull request Jan 25, 2021
Merged
4 tasks
@trop trop Bot added 9-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jan 25, 2021
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jan 25, 2021
@codebytere
Copy link
Copy Markdown
Member

codebytere commented Jan 25, 2021

@miniak

ERROR in /home/builduser/project/src/electron/lib/renderer/web-view/web-view-impl.ts
./lib/renderer/web-view/web-view-impl.ts
[tsl] ERROR in /home/builduser/project/src/electron/lib/renderer/web-view/web-view-impl.ts(44,19)
TS2531: Object is possibly 'null'.

@miniak miniak force-pushed the trop/9-x-y-bp-fix-webview-not-working-with-trusted-types-1611538197763 branch from 214dba2 to 7e68749 Compare January 25, 2021 17:05
@miniak
Copy link
Copy Markdown
Contributor

miniak commented Jan 25, 2021 •
edited
Loading

@codebytere fixed, for some reason ownerDocument is declared as nullable in the TypeScript version used in this branch

@codebytere codebytere merged commit f23cfbe into 9-x-y Jan 25, 2021
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Jan 25, 2021

Release Notes Persisted

Fixed &lt;webview&gt; not working with Trusted Types.

@trop trop Bot deleted the trop/9-x-y-bp-fix-webview-not-working-with-trusted-types-1611538197763 branch January 25, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miniak miniak miniak approved these changes

Assignees

No one assigned

Labels

9-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codebytere @miniak