Skip to content

chore: cherry-pick ffd6ff5a61b9 from v8#27413

Merged
zcbenz merged 2 commits into9-x-yfrom
cherry-pick/9-x-y/v8/ffd6ff5a61b9
Jan 21, 2021
Merged

chore: cherry-pick ffd6ff5a61b9 from v8#27413
zcbenz merged 2 commits into9-x-yfrom
cherry-pick/9-x-y/v8/ffd6ff5a61b9

Conversation

@ppontes
Copy link
Copy Markdown
Member

@ppontes ppontes commented Jan 20, 2021

Merged: [wasm-simd] Fix loading fp pair registers

We were incorrectly clearing the high reg from the list of regs to load.
The intention was to prevent double (and incorrect) loading - loading
128 bits from the low fp and the loading 128 bits from the high fp.
But this violates the assumption that the two regs in a pair would be
set or unset at the same time.

The fix here is to introduce a new enum for register loads, a nop, which
does nothing. The high fp of the fp pair will be tied to this nop, so as
we iterate down the reglist, we load 128 bits using the low fp, then
don't load anything for the high fp.

Bug: chromium:1161654
(cherry picked from commit 8c698702ced0de085aa91370d8cb44deab3fcf54)

Change-Id: Ib8134574b24f74f24ca9efd34b3444173296d8f1
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2619416
Commit-Queue: Zhi An Ng zhin@chromium.org
Reviewed-by: Clemens Backes clemensb@chromium.org
Cr-Commit-Position: refs/branch-heads/8.8@{#28}
Cr-Branched-From: 2dbcdc105b963ee2501c82139eef7e0603977ff0-refs/heads/8.8.278@{#1}
Cr-Branched-From: 366d30c99049b3f1c673f8a93deb9f879d0fa9f0-refs/heads/master@{#71094}

Notes: Security: backported fix for chromium:1161654.

@ppontes ppontes requested a review from a team as a code owner January 20, 2021 17:10
@ppontes ppontes added 9-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Jan 20, 2021
@electron-cation electron-cation Bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Jan 20, 2021
@zcbenz zcbenz merged commit fd76e72 into 9-x-y Jan 21, 2021
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Jan 21, 2021

Release Notes Persisted

Security: backported fix for chromium:1161654.

@zcbenz zcbenz deleted the cherry-pick/9-x-y/v8/ffd6ff5a61b9 branch January 21, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants