Reverts create container cmd regression. #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - Adds Memory and MemorySwap related methods to CreateContainerCmd interface and related interface. This was done so that the test-containers project can bump it's docker-java dependency for support to the latest docker version. See testcontainers/testcontainers-java#1340 for more. Note that this commit is a continuation of #1203, wherein I failed to see that these two methods were not reverted back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This was done so that the test-containers project can bump its docker-java dependency for support to the latest docker version.
See testcontainers/testcontainers-java#1340 for more.
Note that this commit is a continuation of #1203, wherein I failed to see that these two methods were not reverted back.
This change is