is this supposed to be images here?

yes good catch

should be good

I think splitting by = makes something like this invalid

name=lucacome/test-foo2,enable=${{ github.event_name == 'pull_request' }}

not sure if you ever meant for it to be supported and I guess I could always have the same condition with other operators like startsWith without using =

${{ github.event_name == 'pull_request' }} is interpreted upstream by the GitHub Runner logic so it would produce name=lucacome/test-foo2,enable=<true|false> before being passed to the action.

ah interesting, I thought that was the cause for Error: Image name attribute empty: enable=true that I'm seeing, but then I'm not sure I understand what this error means 😄

I have this and I assumed it wasn't coming from the first one, as it would get the default enable=true, and that it was the second line causing the error.

images: |
  name=lucacome/test-foo
  name=lucacome/test-foo2,enable=${{ github.event_name == 'pull_request' }}
  name=ghcr.io/lucacome/workflows,enable=${{ startsWith(github.ref, 'refs/tags/') && contains(matrix.target, 'aws') }}

Oh sounds like a bug then, will take a look, thanks for your feedback

@lucacome Hum I was not able to repro, do you have a link to your repo?

@crazy-max I have this repo where I test workflows https://github.com/lucacome/workflows/runs/6178399824?check_suite_focus=true

Ok was able to repro: https://github.com/docker/metadata-action/runs/6195927044?check_suite_focus=true#step:3:19

@lucacome Should be fixed, let me know if it looks good to you. Thanks!

LGTM! 🚀