Lazily check for foreign exes which may not be necessary for the curr…#1257
Merged
nedtwigg merged 6 commits intodiffplug:mainfrom Jul 27, 2022
Merged
Lazily check for foreign exes which may not be necessary for the curr…#1257nedtwigg merged 6 commits intodiffplug:mainfrom
nedtwigg merged 6 commits intodiffplug:mainfrom
Conversation
nedtwigg
requested changes
Jul 12, 2022
Contributor
Author
|
I processed your comments. Running |
Contributor
Author
|
Not even |
Member
|
Sorry for the slow merge. I'll get this released by tomorrow. The spotlessApply issue you were bumping into is #1238 |
nedtwigg
approved these changes
Jul 26, 2022
Member
|
Sorry for the slow turnaround - finally released in |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run ForeignExe#confirmVersionAndGetAbsolutePath only once it is necessary.
Discussed in #673, I decided to make the 2 State implementations lazy with resolving the arguments.