Merged
Conversation
Member
|
rerun tests |
Closed
Member
Author
|
Okay, so this isn't ideal but rerunning these two tests has resulted in three consecutive all-green CI runs. Ultimately I want to close #9793 properly, but in the meantime I think rerunning is okay temporarily. Having red Xs in CI is confusing to new contributors, slows down development, and increases the chance miss a non-flaky failure. cc @rjzamora @j-bennet @charlesbluca for thoughts |
Contributor
|
+1, I think re-running these tests is a lesser evil than constantly get false positives that the build is broken when it's not really broken. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref #9793